Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Integrate Arm Compute Library (ACL) as an in-tree module into oneDNN #2076

Open
snadampal opened this issue Sep 3, 2024 · 5 comments
Open
Labels

Comments

@snadampal
Copy link
Contributor

With oneDNN and ACL tightly coupled for aarch64 builds, having them in two repos is making it harder to keep the versions in sync. The request here is to bring ACL sources into oneDNN, may be as a git submodule.

This is a well known integration topic, that's why i'm not creating any detailed RFC document. I can create one if required.

@snadampal snadampal added question RFC A design document labels Sep 3, 2024
@theComputeKid
Copy link
Member

I recall this was discussed before with the oneDNN team and our current recommendation is for the developer to link against the latest release of ACL themselves rather than building in-source. Perhaps we can discuss this in person, to understand your requirements and pain points better.

@vpirogov vpirogov removed the RFC A design document label Nov 15, 2024
@snadampal
Copy link
Contributor Author

Hi @theComputeKid , @vpirogov , we discussed it briefly but didn't align on the next steps. Given both PyTorch and oneDNN are moving faster, the pain of updating ACL is also increasing every time, for example, look at this issue: pytorch/pytorch#138889
Can we please prioritize brining ACL into oneDNN tree for the next oneDNN release?

@vpirogov
Copy link
Member

@snadampal, I believe we have multiple options to address pains on Pytorch side and also we need to consider other users, like OpenVINO. So to move forward we need a proper RFC with meaningful discussion of options.

@snadampal
Copy link
Contributor Author

I agree @vpirogov , let me create a doc with all the options.

@vpirogov
Copy link
Member

Opened a request to introduce semantic versioning in ACL: ARM-software/ComputeLibrary#1149

This is a must to avoid dependency hell for projects that have direct use of oneDNN and ACL, like OpenVINO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants