Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limited CI #1756

Merged
Merged

Conversation

lslusarczyk
Copy link
Contributor

temprorarily disabled all tests except DR ones to speed up applying DR review comments

change to be reverted

@akukanov
Copy link
Contributor

akukanov commented Aug 2, 2024

@danhoeflinger @dmitriy-sobolev @timmiesmith - is there a "better" way to do what @lslusarczyk wants for CI in the distributed-ranges branch?

@danhoeflinger
Copy link
Contributor

danhoeflinger commented Aug 2, 2024

@danhoeflinger @dmitriy-sobolev @timmiesmith - is there a "better" way to do what @lslusarczyk wants for CI in the distributed-ranges branch?

Umm, this is kind of the "quick and dirty" way of doing it, which I don't really object to. It makes it reasonably obvious that it should be removed.

I think there are ways to exclude runs from the matrix based upon branch name matching. That would allow us to do the same with some fewer lines of code I think. Is it necessary in this scenario where the intention is to revert this?
I'm not sure.

https://github.com/orgs/community/discussions/26253

Perhaps there is some better way still that I'm missing...

@lslusarczyk
Copy link
Contributor Author

Thanks for looking into this. If we find a better way I will revert this change and disable in a new way. For now I'm merging it.

It has an advantage that it is so dirty that nobody will forget about reverting this change.

@lslusarczyk lslusarczyk merged commit d6f21d3 into uxlfoundation:distributed-ranges Aug 2, 2024
4 checks passed
@lslusarczyk lslusarczyk deleted the limited-CI branch August 2, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants