Moving task_group_exptensions out of the preview #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all but : - is_inside_task - scheduller bypass Signed-off-by: Anton Potapov <anton.potapov@intel.com>
anton-potapov
force-pushed
the
task_handle_unpreview
branch
from
72bacf2 to
0febcaf
Compare
isaevil
reviewed
Nov 30, 2021
Co-authored-by: Ilya Isaev <ilya.isaev@intel.com>
- removed duplicated test case Signed-off-by: Anton Potapov <anton.potapov@intel.com>
|
Should we check somewhere for |
- replaced exceptions with asserts for undefined behaviour Signed-off-by: Anton Potapov <anton.potapov@intel.com>
anton-potapov
force-pushed
the
task_handle_unpreview
branch
from
6e0b42b to
5cb7016
Compare
- added test for task_handle being non copyable Signed-off-by: Anton Potapov <anton.potapov@intel.com>
added |
anton-potapov
changed the title
| oneapi::tbb::task_handle h; | ||
|
|
||
| oneapi::tbb::task_group tg; | ||
| std::atomic<bool> run {false}; |
| TEST_CASE("Task handle blocks wait"){ | ||
| oneapi::tbb::task_group tg; | ||
|
|
||
| std::atomic<bool> completed {false}; |
There was a problem hiding this comment.
Make completed to be non-atomic
Co-authored-by: Alex <alexei.katranov@intel.com>
- made some flags in the tests non-atomic for TSAN to raise a flag if implementation is incorrect Signed-off-by: Anton Potapov <anton.potapov@intel.com>
alexey-katranov
approved these changes
Dec 21, 2021
kboyarinov
pushed a commit
that referenced
this pull request
Dec 27, 2021
Moving task_group_exptensions out of the preview - moved all but : - is_inside_task - scheduller bypass - replaced exceptions with asserts for undefined behavior - made some flags in the tests non-atomic for TSAN to raise a flag if implementation is incorrect Signed-off-by: Anton Potapov <anton.potapov@intel.com> Co-authored-by: Ilya Isaev <ilya.isaev@intel.com> Co-authored-by: Alex <alexei.katranov@intel.com>
anton-potapov
added a commit
to anton-potapov/oneTBB
that referenced
this pull request
Jan 13, 2022
Signed-off-by: Anton Potapov <anton.potapov@intel.com>
14 tasks
anton-potapov
added a commit
that referenced
this pull request
Jan 17, 2022
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
task_handleand related out of Preview features to be aligned withoneAPI V1.1 rev 1 :
Following features, as not part of the spec are still preview ones:
is_inside_taskfunctiontask_handleFixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information