Skip to content

Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
EwanC opened this issue Jan 22, 2025 · 5 comments · Fixed by #2606
Closed

Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp #2600

EwanC opened this issue Jan 22, 2025 · 5 comments · Fixed by #2606
Assignees
@EwanC
Labels
command-buffer Command Buffer feature addition/changes/specification

Comments

@EwanC
Copy link
Contributor

EwanC commented Jan 22, 2025

The API to enqueue a closed command-buffer to a queue is defined in the YAML as a part of the command-buffer class, but it should be part of the enqueue class like other enqueue API extensions. This would switch around the prefix.
@EwanC EwanC added the command-buffer Command Buffer feature addition/changes/specification label Jan 22, 2025
@EwanC EwanC self-assigned this Jan 22, 2025
@EwanC EwanC mentioned this issue Jan 22, 2025
Closed
EwanC added a commit to Bensuo/unified-runtime that referenced this issue Jan 23, 2025
@EwanC
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp
d96133f 
The API to enqueue a closed command-buffer to a queue is defined
in the YAML as a part of the command-buffer class, but it should be
part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated
changes to adapters and CTS.

Closes oneapi-src#2600
@EwanC EwanC mentioned this issue Jan 23, 2025
Merged
EwanC added a commit to Bensuo/unified-runtime that referenced this issue Jan 23, 2025
@EwanC
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp
aec66e8 
The API to enqueue a closed command-buffer to a queue is defined
in the YAML as a part of the command-buffer class, but it should be
part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated
changes to adapters and CTS.

Closes oneapi-src#2600
EwanC added a commit to Bensuo/unified-runtime that referenced this issue Jan 23, 2025
@EwanC
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp
c62847a 
The API to enqueue a closed command-buffer to a queue is defined
in the YAML as a part of the command-buffer class, but it should be
part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated
changes to adapters and CTS.

Closes oneapi-src#2600
@EwanC
Copy link
Contributor Author

EwanC commented Jan 23, 2025

PR addressing this #2606

EwanC added a commit to Bensuo/unified-runtime that referenced this issue Jan 29, 2025
@EwanC
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp
f4234a7 
The API to enqueue a closed command-buffer to a queue is defined
in the YAML as a part of the command-buffer class, but it should be
part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated
changes to adapters and CTS.

Closes oneapi-src#2600
EwanC added a commit to Bensuo/unified-runtime that referenced this issue Jan 29, 2025
@EwanC
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp
a86f530 
The API to enqueue a closed command-buffer to a queue is defined
in the YAML as a part of the command-buffer class, but it should be
part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated
changes to adapters and CTS.

Closes oneapi-src#2600
EwanC added a commit to Bensuo/unified-runtime that referenced this issue Jan 29, 2025
@EwanC
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp
2bb9744 
The API to enqueue a closed command-buffer to a queue is defined
in the YAML as a part of the command-buffer class, but it should be
part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated
changes to adapters and CTS.

Closes oneapi-src#2600
@kbenzie kbenzie closed this as completed in ec5a3bd Feb 6, 2025
nrspruit pushed a commit to nrspruit/unified-runtime that referenced this issue Feb 7, 2025
@EwanC @nrspruit
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp
81a5ac8 
The API to enqueue a closed command-buffer to a queue is defined
in the YAML as a part of the command-buffer class, but it should be
part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated
changes to adapters and CTS.

Closes oneapi-src#2600
yingcong-wu pushed a commit to yingcong-wu/unified-runtime that referenced this issue Feb 8, 2025
@EwanC @yingcong-wu
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp
0035e84 
The API to enqueue a closed command-buffer to a queue is defined
in the YAML as a part of the command-buffer class, but it should be
part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated
changes to adapters and CTS.

Closes oneapi-src#2600
nrspruit pushed a commit to nrspruit/unified-runtime that referenced this issue Feb 10, 2025
@EwanC @nrspruit
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp
ed5636f 
The API to enqueue a closed command-buffer to a queue is defined
in the YAML as a part of the command-buffer class, but it should be
part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated
changes to adapters and CTS.

Closes oneapi-src#2600
@EwanC
Copy link
Contributor Author

EwanC commented Feb 11, 2025

Reopening this, as change needs to be reverted in #2688

@EwanC EwanC reopened this Feb 11, 2025
EwanC added a commit to Bensuo/unified-runtime that referenced this issue Feb 12, 2025
@EwanC
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp
fbe39fd 
**Same patch as oneapi-src#2606
which was reverted due to intel/llvm#16982

The API to enqueue a closed command-buffer to a queue is defined in the YAML as a part of the command-buffer class, but it should be part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated changes to adapters and CTS.

Closes oneapi-src#2600
@EwanC EwanC mentioned this issue Feb 12, 2025
Closed
EwanC added a commit to Bensuo/unified-runtime that referenced this issue Feb 18, 2025
@EwanC
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp
0938387 
**Same patch as oneapi-src#2606
which was reverted due to intel/llvm#16982

The API to enqueue a closed command-buffer to a queue is defined in the YAML as a part of the command-buffer class, but it should be part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated changes to adapters and CTS.

Closes oneapi-src#2600
@EwanC EwanC mentioned this issue Feb 19, 2025
Merged
@kbenzie
Copy link
Contributor

kbenzie commented Feb 19, 2025

@RossBrunton should this have been closed yet? Seems like the change only exists in your fork at the moment, unless I'm missing something.

@RossBrunton
Copy link
Contributor

... I just synced RossBrunton/sycl to pull in intel/sycl and I guess it saw there was a commit containing Closes https://github.com/oneapi-src/unified-runtime/issues/2600... So it decided to close it.

Github why.

@RossBrunton RossBrunton reopened this Feb 19, 2025
sommerlukas pushed a commit to intel/llvm that referenced this issue Mar 6, 2025
@EwanC
[SYCL][Graph][UR] Rename cmd-buf enqueue entry-point (#16984)
474235e 
**Same PR as was closed in #16747 due
to CI issue #16982 which has since
been resolved.**

The API to enqueue a closed command-buffer to a queue is defined in the
YAML as a part of the command-buffer class, but it should be part of the
enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated
changes to adapters and CTS.

Closes UR issue
oneapi-src/unified-runtime#2600
RossBrunton pushed a commit that referenced this issue Mar 6, 2025
@EwanC @RossBrunton
Rename cmd-buf enqueue entry-point (#16984)
0f5aef9 
**Same PR as was closed in intel/llvm#16747 due
to CI issue intel/llvm#16982 which has since
been resolved.**

The API to enqueue a closed command-buffer to a queue is defined in the
YAML as a part of the command-buffer class, but it should be part of the
enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated
changes to adapters and CTS.

Closes UR issue
#2600
@kbenzie
Copy link
Contributor

kbenzie commented Apr 8, 2025

Implemented in intel/llvm#16984

@kbenzie kbenzie closed this as completed Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EwanC EwanC

Labels
command-buffer Command Buffer feature addition/changes/specification
Projects
None yet
Milestone
No milestone
3 participants
@RossBrunton @kbenzie @EwanC