Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp #2600

Open
EwanC opened this issue Jan 22, 2025 · 1 comment · May be fixed by #2606
Open

Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp #2600

EwanC opened this issue Jan 22, 2025 · 1 comment · May be fixed by #2606
Assignees
@EwanC
Labels
command-buffer Command Buffer feature addition/changes/specification

Comments

@EwanC
Copy link
Contributor

EwanC commented Jan 22, 2025

The API to enqueue a closed command-buffer to a queue is defined in the YAML as a part of the command-buffer class, but it should be part of the enqueue class like other enqueue API extensions. This would switch around the prefix.
@EwanC EwanC added the command-buffer Command Buffer feature addition/changes/specification label Jan 22, 2025
@EwanC EwanC self-assigned this Jan 22, 2025
@EwanC EwanC mentioned this issue Jan 22, 2025
Open
EwanC added a commit to Bensuo/unified-runtime that referenced this issue Jan 23, 2025
@EwanC
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp
d96133f 
The API to enqueue a closed command-buffer to a queue is defined
in the YAML as a part of the command-buffer class, but it should be
part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated
changes to adapters and CTS.

Closes oneapi-src#2600
@EwanC EwanC linked a pull request Jan 23, 2025 that will close this issue
Open
EwanC added a commit to Bensuo/unified-runtime that referenced this issue Jan 23, 2025
@EwanC
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp
aec66e8 
The API to enqueue a closed command-buffer to a queue is defined
in the YAML as a part of the command-buffer class, but it should be
part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated
changes to adapters and CTS.

Closes oneapi-src#2600
EwanC added a commit to Bensuo/unified-runtime that referenced this issue Jan 23, 2025
@EwanC
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp
c62847a 
The API to enqueue a closed command-buffer to a queue is defined
in the YAML as a part of the command-buffer class, but it should be
part of the enqueue class like other enqueue API extensions.

This PR updates the YAML and regenerates UR code, making the associated
changes to adapters and CTS.

Closes oneapi-src#2600
@EwanC
Copy link
Contributor Author

EwanC commented Jan 23, 2025

PR addressing this #2606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EwanC EwanC

Labels
command-buffer Command Buffer feature addition/changes/specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp Bensuo/unified-runtime
1 participant
@EwanC