-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Ruby 3.1 net/http IPv6 HTTP(S) requests are much slower than Ruby 3.0 #264
Comments
gem
command on Windows seems noticeably slower than Ruby 3.0
@larskanis any thoughts on this? |
OK, I've determined that its due to HTTPS being slow. This script reproduces the issue require 'net/http'
uri = URI('https://www.google.com')
Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https') do |http|
request = Net::HTTP::Get.new uri
response = http.request request # very slow
end Edited ticket description to reflect this. |
gem
command on Windows seems noticeably slower than Ruby 3.0
Tried seeing if it's DNS related, doesn't look to be. Here's a script to use google DNS class Resolv
def self.use_google_dns
# dns
nameservers = ['8.8.8.8', '8.8.4.4']
dns = Resolv::DNS.new(nameserver: nameservers, search: ['mydns.com'], ndots: 1)
# resolver
hosts = Resolv::Hosts.new()
resolver = new([hosts, dns])
# replace constant
remove_const :DefaultResolver
const_set :DefaultResolver, resolver
end
end
# replace
require 'resolv-replace'
# use google's DNS servers
Resolv.use_google_dns |
@larskanis this seems IPv6 related. The following URL which only supports IPv4 is very fast: require 'net/http'
uri = URI('https://global.jd.com')
Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https') do |http|
request = Net::HTTP::Get.new uri
response = http.request request # <-- fast!
end Adding to description. |
@johnnyshields I tried, but I'm not seeing the same issue:
Code: require 'uri'
require 'net/http'
require 'openssl'
module HTTPS_IPv4_IPv6
class << self
def run(uri_str)
uri = URI(uri_str)
puts uri_str
t_st = Process.clock_gettime(Process::CLOCK_MONOTONIC)
Net::HTTP.start(uri.host, uri.port, use_ssl: true, verify_mode: OpenSSL::SSL::VERIFY_PEER) do |http|
req = Net::HTTP::Get.new uri.request_uri
resp = http.request req
case resp
when Net::HTTPSuccess
body = resp.body
t_end = Process.clock_gettime(Process::CLOCK_MONOTONIC)
puts "body bytesize #{body.bytesize}"
puts format("response time %6.3f sec", t_end - t_st)
puts http.instance_variable_get(:@socket).io.to_io.remote_address.inspect, ''
when Net::HTTPRedirection
puts "#{resp.class}\n Redirect: #{resp['location']}"
run resp['location']
else
puts resp.class
end
end
end
end
end
puts '', RUBY_DESCRIPTION, ''
HTTPS_IPv4_IPv6.run 'https://www.google.com'
HTTPS_IPv4_IPv6.run 'https://msp-greg.github.io'
HTTPS_IPv4_IPv6.run 'https://global.jd.com' |
Thank you for this! Output I get from your script (* using OpenSSL::SSL::VERIFY_NONE) ruby 3.1.1p18 (2022-02-18 revision 53f5fc4236) [x64-mingw-ucrt]
irb(main):079:0> HTTPS_IPv4_IPv6.run 'https://www.google.com'
https://www.google.com
body bytesize 15108
response time 60.162 sec
#<Addrinfo: 172.217.26.228:443 TCP>
irb(main):084:0> HTTPS_IPv4_IPv6.run 'https://msp-greg.github.io'
https://msp-greg.github.io
body bytesize 22161
response time 240.197 sec
#<Addrinfo: 185.199.110.153:443 TCP>
irb(main):081:0> HTTPS_IPv4_IPv6.run 'https://global.jd.com'
https://global.jd.com
body bytesize 20592
response time 0.384 sec
#<Addrinfo: 14.0.43.163:443 TCP> The "60 sec + X milliseconds" in the google.com run (IPv6) is very curious. Verified it's always 60 sec. Must be something non-critical is timing out after 60 sec, need to investigate what is causing it. Something is def strange because Ruby 3.0, 2.7, 2.6, etc. on my machine are all installed with Ruby Windows Installer and all of them work fine. I'm in Tokyo, Japan, by the way, so maybe that has something to with it. |
It is interesting that you're having issues. I first was using ruby master, and the times were similar. Do you see any difference using EDIT: It looks like your network isn't using IPv6, all the addresses are IPv4? Note that my output has IPv6 addresses for Google and GitHub, but IPv4 for global.jd.com. |
My hunch is that Ruby is failing IPv6 entirely and then falling back to IPv4 after 60 secs. With Ruby 3.0, I get this--looks like it's also using IPv4, but not doing a long timeout for IPv6. So something is causing Ruby 3.1 to wait for up to 60 sec for the IPv6 timeout. ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [x64-mingw32]
irb(main):040:0> HTTPS_IPv4_IPv6.run 'https://www.google.com'
https://www.google.com
body bytesize 15110
response time 2.390 sec
#<Addrinfo: 142.251.42.196:443 TCP>
irb(main):042:0> HTTPS_IPv4_IPv6.run 'https://msp-greg.github.io'
https://msp-greg.github.io
body bytesize 22161
response time 0.207 sec
#<Addrinfo: 185.199.110.153:443 TCP>
irb(main):044:0> HTTPS_IPv4_IPv6.run 'https://global.jd.com'
https://global.jd.com
body bytesize 20592
response time 0.633 sec
#<Addrinfo: 14.0.43.163:443 TCP> |
Can you test on any other platforms? Not sure if it's a Windows issue. Since my network is different, not sure if I can repo what you're seeing... I've got WSL2/Ubuntu, both 20.04 and 22.04, but it's only running IPv4. I guess I should figure out how to change that... |
Yes, I'll check investigate more in next few days. Based on the info we have, my hypothesis is:
|
Confirmed that Ruby 3.1 on WSL Linux (same machine) does not have this issue. As per above it is using IPv4 only, as expected since it's the same machine.
|
Question - in your network adapter properties, is IPv6 checked/enabled? If so, and if you uncheck it, do the Windows connection times drop? JFYI, haven't gotten IPv6 working with WSL2, not even sure it's possible.. |
Disabling IPv6 on adapter does not seem to have any effect--I see the 60s latency either way. |
Interesting. JFYI, I tried the most recent releases back to 2.5, and all connected to the IPv6 addresses. |
I'm surprised that setting |
@MSP-Greg here's a bit more pinpointing of the issue. It's happening in Socket.tcp, my hunch is that there's some difference in the native code that Socket uses between the two Ruby versions. AFAIK the socket timeout itself is set to 60 sec in both Ruby 3.0 and Ruby 3.1, the difference is that Ruby 3.0 somehow "short-circuits" that timeout immediately, while Ruby 3.1 waits until the end. require 'net/http'
TIMEOUT = 5
# This code is where the issue happens
# s = Socket.tcp "google.com", 80, nil, nil, connect_timeout: TIMEOUT
# Demonstrates the issue inside Socket.tcp
puts '', RUBY_DESCRIPTION, ''
t = nil
Addrinfo.foreach("google.com", 80, nil, :STREAM) do |ai|
puts ai.inspect
t = Time.now
ai.connect(timeout: TIMEOUT)
rescue SystemCallError
puts "Failed after #{Time.now - t} sec", ''
end
puts "Success after #{Time.now - t} sec"
|
OK, think I have a clue. Under the hood, Ruby 3.0 Net::HTTP uses: # net/http.rb line 985
s = Timeout.timeout(@open_timeout, Net::OpenTimeout) {
begin
TCPSocket.open(conn_addr, conn_port, @local_host, @local_port) While Ruby 3.1 Net::HTTP uses: # net/http.rb line 998
s = Socket.tcp conn_addr, conn_port, @local_host, @local_port, connect_timeout: @open_timeout For me, TCPSocket.open is fast on both versions, and Socket.tcp is slow on both versions. Socket.tcp "google.com", 80, nil, nil, connect_timeout: 60
TCPSocket.open("google.com", 80, nil, nil) |
And here is the change that did it: ruby/net-http#10 |
Issue filed with Net::HTTP: ruby/net-http#57 |
Well, at least I can monkey-patch in the old |
This is interesting for RubyGems, because we're monkey-patching |
IDK. With a network (including ISP) fully supporting IPv6, there aren't issues. But, maybe the timeouts in http are a bit long for 'modern day' networks?
|
If I recall correctly, the problem was that Ruby networking APIs do not implement happy eyeballs. Our monkey patch in RubyGems is intended to workaround that. There was some work in progress in ruby-core to implement this but it was never completed: ruby/ruby#4038. |
@sonalkr132 I think our monkey-patch to |
Same issue on Linux machine, ruby 3.1.
to:
|
For what it's worth, the |
What problems are you experiencing?
net/http
requests using IPv6 are significantly slower on Ruby 3.1 than on previous versions.Steps to reproduce
What's the output from
ridk version
?Original Ticket: Rubgems is slow on Ruby 3.1
Installed
RubyInstaller 3.1.1-1
. Runninggem install
andbundle install
seems noticeably slower than on Ruby 3.0. Evengem update --system
is very slow; takes several minutes before any log lines print at all.Doing
gem update --system
(update torubygems-3.3.9
) doesn't seem to make any difference.I ran some basic code benchmarks on
irb
and there wasn't a major performance difference between the two versions.The text was updated successfully, but these errors were encountered: