Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage api cleanup: mac-linux regularity #257

Open
ransomw1c opened this issue Sep 7, 2019 · 0 comments
Open

storage api cleanup: mac-linux regularity #257

ransomw1c opened this issue Sep 7, 2019 · 0 comments
Labels
backend issues related to the backend services datamon depends on harmonization Internal code changes that do not result in bug fixes or new features. P1 This is next and will move to P0 once planned.

Comments

@ransomw1c
Copy link
Contributor

all of the internal api in this file is kinda of a disaster area: what's convenient to debug, isn't always convenient to maintain.

using Delete and Put calls rather than calling Put with a storage.Overwrite parameter is particularly egregious, however: the storage.Overwrite parameter does something different in CI (linux) than local (mac), and this needs to be tested and fixed as a separate issue.

Originally posted by @ransomw1c in https://github.com/oneconcern/datamon/diffs
@ransomw1c ransomw1c added backend issues related to the backend services datamon depends on harmonization Internal code changes that do not result in bug fixes or new features. P1 This is next and will move to P0 once planned. labels Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend issues related to the backend services datamon depends on harmonization Internal code changes that do not result in bug fixes or new features. P1 This is next and will move to P0 once planned.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ransomw1c