3.0.0 Signature validation fails when using ADFS 3.0 as IdP with encryption

[gmoniker]

I am offering a new method of importing a decrypted assertion into the XML document to replace the EncryptedAssertion. This method should solve the problem of Assertions using default namespace declarations which get mangled by importNode with deep cloning and then do not pass signature verification.

This solves problems when the IdP signs its assertion and encrypts it, AND uses default namespaces in the Assertion elements. As for example with ADFS 3.0.

[gmoniker]

Travis testing is failing.

It seems that you have to use --root-dir in .travis.yml now in the call to vendor/bin/coveralls and remove src_dir in .coveralls.yml
See WordPoints/dev-lib#109

Also I saw a hint that it would be better to set coveralls task in after_succes in .travis.yml.

[pitbulk]

Thanks, I will review that tomorrow and let you know. Thanks for contributing!.

[pitbulk]

@gmoniker can you add a Test with an example of a SAMLResponse with encrypted assertion that failed previously and is working now? (if you can use the private key/public cert located here so we avoid to introduce in the future any change that break it.

btw Travis reported the following issues:

FILE: /home/travis/build/onelogin/php-saml/lib/Saml2/Utils.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 180 | ERROR | [x] Opening brace should be on a new line
 191 | ERROR | [ ] Expected "foreach (...) {\n"; found "foreach(...) {\n"

Once fixed, it should pass (check how past a recent commit).

[gmoniker]

@pitbulk

Just discovered that the treeCopyReplace routine I created became part of the onelogin codebase. Awesome. 😀