Move the creation of the AuthnRequest to separate function #367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the creation of the AuthnRequest to a separate function, it's easier to extend the
Auth
class to use a customAuthnRequest
(to implement extra features like in #211). This way, only thebuildAuthnRequest()
function has to be overridden.In the current implementation, overriding the
login()
function to achieve the same goal causes some problems with private variables such as_settings
.