Fix for SLO when XML specifies encoding #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding bytes_type to compat - Changing OneLogin_Saml2_XML.to_etree() to always pass bytes to _parse_etree() - Adding test cases for SLO messages with XML encoding specified
|
Thanks for contributing this, I will review and merge. |
… tests, allowing remote IdP tests to pass also when offline.
OP-Lamminen
force-pushed
the
slo-with-xml-encoding
branch
from
b016e66 to
771072e
Compare
|
@OP-Lamminen thanks for contributing this. @lgasperin thanks for your comment, I don't know why I missed to merge it after validating. |
This was referenced Mar 27, 2019
kitsook
added a commit
to ubc/compair
that referenced
this pull request
Jul 15, 2020
- MariaDB 10.4.13 crashes when running upgrade script to change encoding. Works fine with 10.1, 10.4.12, and 10.5 though. So upgrading devstack to use 10.5 (currently 10.5.4) - encountered errors when doing saml logout with cwl. upgrading python3-saml. SAML-Toolkits/python3-saml#127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #60, fix #81 and fix #95.