Allow validate_subject_confirmation Response validation to be skipped #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kipped with a skip_subject_confirmation flag passed when initializing the Response
This was referenced Aug 18, 2015
pitbulk
added a commit
that referenced
this pull request
Aug 18, 2015
…ion_flag Allow validate_subject_confirmation Response validation to be skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Migrations
NO
Description
When you are initializing a new OneLogin::RubySaml::Response, this adds an additional option called skip_subject_confirmation. When skip_subject_confirmation is true, the validate_subject_confirmation validation is skipped
Related PRs
List related PRs against other branches:
none
Todos
Deploy Notes
No deploy notes. After the deploy there will be a new option available to you.
Steps to Test or Reproduce
Run validations on an assertion with a bad Subject > SubjectConfirmation. They should fail.
Then initialize a OneLogin::RubySaml::Response with {skip_subject_confirmation: true} in the options. Now the bad assertion will pass validations.
Impacted Areas in Application
This affects the saml validations that are run on your Response. By default nothing will change. If you pass {skip_subject_confirmation: true} to the OneLogin::RubySaml::Response, the subject confirmation validation will be skipped