Partial attributes to security settings doesn't nullify missing ones #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you are right and the current behavior can confuse the developers. In order to maintain compatibility, and reduce confusion, what do you think if we add a second parameter, by default the old behavior, to control when or not respect security values? |
davidlibrera
force-pushed
the
bug/security-attributes-override
branch
from
11cecaa to
b37366e
Compare
|
Great! I changed the method with b37366e and I added another example in order to test both behaviours. Do you agree? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I supposed this was a bug, because if I want to enable metadata signing I need to provide all attributes, while I just want to enable it without change other attributes.