Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add select.nodepool parameter type #809

Merged
merged 52 commits into from
Dec 29, 2020
Merged

Conversation

rushtehrani
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes onepanelio/core#

Special notes for your reviewer:

Checklist

Please check if applies

  • I have added/updated relevant unit tests
  • I have added/updated relevant documentation

Required

  • I accept to release these changes under the Apache 2.0 License

Vafilor and others added 30 commits December 19, 2020 20:52
… This will perform any modifications needed to replace types with runtime data, etc.

An example is select.nodepool. This value should set the options to the currently available node types.
…logic to replace select.nodepool values with runtime values.
…sources for migrations.

Also updated migration yamls to the latest based on templates repo.
… This will perform any modifications needed to replace types with runtime data, etc.

An example is select.nodepool. This value should set the options to the currently available node types.
…logic to replace select.nodepool values with runtime values.
@rushtehrani
Copy link
Contributor Author

rushtehrani commented Dec 27, 2020

@Vafilor issues so far:

  • Comments in Workflows (might be the case with Workspaces too) are getting removed - for example I commented out nodeSelector and it was gone when I went back to edit the template.
  • Adding a select.nodepool and saving seems to auto inject options when I go back to edit the template.
  • This maybe due to the UI changes but filters are not working - they're all returning 403 errors, looks like labels is being passed as a namespace"
time="2020-12-28T06:00:32Z" level=warning msg="finished unary call with code PermissionDenied" error="rpc error: code = PermissionDenied desc = Permission denied. Namespace: 'labels', Verb: 'get', Group: '', Resource '', Name: ''" grpc.code=PermissionDenied grpc.method=GetLabels grpc.service=api.LabelService grpc.start_time="2020-12-28T06:00:32Z" grpc.time_ms=3.078 span.kind=server system=g

Note that migrations don't have this issue - this only happens when saving from web UI.

@rushtehrani rushtehrani changed the title Feat/sys.node.pool feat: Add select.nodepool parameter type Dec 27, 2020
@rushtehrani rushtehrani added this to the v0.17.0 milestone Dec 27, 2020
@Vafilor Vafilor marked this pull request as ready for review December 29, 2020 19:36
@rushtehrani rushtehrani merged commit 95794ba into master Dec 29, 2020
@rushtehrani rushtehrani deleted the feat/sys.node.pool branch December 29, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update migration for TFOD and MaskRCNN New input type select.nodepool
2 participants