Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: introduce new color-neutral token #245

Merged
merged 1 commit into from
Oct 21, 2021
Merged

feat!: introduce new color-neutral token #245

merged 1 commit into from
Oct 21, 2021

Conversation

rabelloo
Copy link
Contributor

Purpose

closes #244

Approach

  • neutral-700 to neutral-200 have been renamed one digit down
  • neutral-700 has been introduced as a new token in place of the old one

Testing

Preview.

Risks

BREAKING CHANGE

Affected users:
Only those using palette tokens, theme token users are unaffected

Migration path:

  1. search neutral-700 to neutral-200 and replace with one digit lower
  • e.g. neutral-700 -> neutral-600
  1. (optional) visually review all neutral-600 and neutral-800
  • potentially use neutral-700 instead

@rabelloo rabelloo added the breaking change Changes that are not retro-compatible label Sep 23, 2021
@vercel
Copy link

vercel bot commented Sep 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/onfido-oss/castor-tokens/KzX5FxUUUoZWaByt6brdQPghbD8H
✅ Preview: https://castor-tokens-git-feat-neutral-onfido-oss.vercel.app

BREAKING CHANGE:
- neutral-700 to neutral-200 have been renamed one digit down
- neutral-700 has been introduced as a new token in place of the old one

Affected users:
Only those using palette tokens, theme token users are unaffected

Migration path:
1. search neutral-700 to neutral-200 and replace with one digit lower
  - e.g. `neutral-700` -> `neutral-600`
2. (optional) visually review all `neutral-600` and `neutral-800`
  - potentially use `neutral-700` instead
@josokinas josokinas merged commit 011a866 into main Oct 21, 2021
@josokinas josokinas deleted the feat/neutral branch October 21, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes that are not retro-compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update neutral palette & separator colors
2 participants