Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OrderedMap.Get() should return Value instead of Storable #317

Closed
fxamacker opened this issue Jun 27, 2023 · 0 comments · Fixed by #318
Closed

OrderedMap.Get() should return Value instead of Storable #317

fxamacker opened this issue Jun 27, 2023 · 0 comments · Fixed by #318
Assignees
@fxamacker
Labels
improvement

Comments

@fxamacker
Copy link
Member

Issue To Be Solved

Currently, OrderedMap.Get() returns Storable and client converts returned Storable to Value. However, it only makes sense to return Storable if client needs to remove register (slab) by StorageID (StorageIDStorable).

Get() should only provide Value without possibility of client manipulating the underlying Storable.

Corresponding issue for Array.Get() is #316.

Suggested Solution

Change OrderedMap.Get() to return Value instead of Storable.

This is prep work for Atree Register Inlining (#292) and will also harden the API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxamacker fxamacker

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change OrderedMap.Get() to return Value instead of Storable onflow/atree
1 participant
@fxamacker