Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slab size computation needs to be changed for atree inlining #335

Closed
fxamacker opened this issue Sep 4, 2023 · 1 comment
Closed

Slab size computation needs to be changed for atree inlining #335

fxamacker opened this issue Sep 4, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@fxamacker
Copy link
Member

Problem

This isn't a problem yet, but it will surface with atree inlining.

When the same value is reset in Array or OrderedMap and its storable is a pointer, slab size computation can be wrong by simply taking a size diff of existing element and new element. This is because existing and new elements are the same and they returns the same storable size, which results in 0 size diff, even if element content is modified and actual size is different.

Suggestion

Change the way slab size is computed in Set functions to avoid the scenario described.

@fxamacker
Copy link
Member Author

This is closed by PRs #336 and #337.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant