Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional memory and storage savings are possible by deduplicating Cadence dictionary type info #358

Closed
fxamacker opened this issue Nov 22, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request performance

Comments

@fxamacker
Copy link
Member

fxamacker commented Nov 22, 2023

Updates #292, onflow/cadence#1854, onflow/flow-go#1744

I think we can deduplicate Cadence dictionary type info, which would further reduce total payload size.

PR #342 added atree inlining which makes data deduplication feasible. Same PR also added data deduplication for:

  • Cadence array type info
  • Cadence composite type info

After examining real data from mainnet, I think the savings can be worthwhile by deduplicating Cadence dictionary type info.

@fxamacker
Copy link
Member Author

Closed by #369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance
Projects
None yet
Development

No branches or pull requests

1 participant