Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract token stream interface from parser #1094

Closed
jsatdapr opened this issue Jul 28, 2021 · 1 comment · Fixed by #1113
Closed

Extract token stream interface from parser #1094

jsatdapr opened this issue Jul 28, 2021 · 1 comment · Fixed by #1113
Assignees

Comments

@jsatdapr
Copy link
Contributor

Issue To Be Solved

The parser-guided fuzzer needs to have a couple alternate implementations of token buffering and token access, and it needs to be switchable at time of Parse(). Previously I tried to use a buildtag to isolate the different implementations, but the parser-guided fuzzer needs to switch at runtime, and needs more than 2 implementations which makes the buildtag approach even more difficult.

Tradeoff

  • There could be a performance hit due to the indirection, but existing prototype work shows no noticeable change in the running time for the full cadence test suite.

Context

The parser-guided-fuzzer is blocked on this.

@jsatdapr
Copy link
Contributor Author

PR coming shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants