Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add purity annotations to newly added functions #2466

Closed
2 tasks done
SupunS opened this issue Apr 24, 2023 · 2 comments
Closed
2 tasks done

Add purity annotations to newly added functions #2466

SupunS opened this issue Apr 24, 2023 · 2 comments
Assignees

Comments

@SupunS
Copy link
Member

SupunS commented Apr 24, 2023

Issue to be solved

There are some native function types added to the master branch, after the purity annotation change was added in stable-cadence. e.g:

When the stable-cadence branch is synced/merged to master, ensure these newly added functions have the proper purity annotation.

Suggested Solution

Scan through all the newly added functions, and added annotations as required.

Tasks

Preview Give feedback
@j1010001
Copy link
Member

j1010001 commented Jan 5, 2024

Do one last pass before the 1.0 release.

@turbolent
Copy link
Member

I ran go run ./runtime/cmd/info -nested -members dump-builtin-types and go run ./runtime/cmd/info -nested -members dump-builtin-values and fixed and other then some missing view annotations for functions related to InclusiveRange I could not see any other issues.

Improved the functions related to InclusiveRange in #3426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants