Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable disabled contract tests #2719

Closed
Tracked by #2642
, #3595
...
dsainati1 opened this issue Aug 15, 2023 · 3 comments · Fixed by #3630
Closed
Tracked by #2642
, #3595
...

Re-enable disabled contract tests #2719

dsainati1 opened this issue Aug 15, 2023 · 3 comments · Fixed by #3630
Assignees
@turbolent
Labels
Technical Debt Testing

Comments

@dsainati1
Copy link
Contributor

Issue to be solved

#2670 disables some tests relying on the FT/NFT standards that use type requirements, testing that those contracts are functional. The tests should be re-enabled once the v2 versions of these standards are finished.

Suggested Solution

No response
@dsainati1 dsainati1 mentioned this issue Aug 15, 2023
Merged
6 tasks
This was referenced Aug 15, 2023
Open
Closed
@turbolent
Copy link
Member

Related: #2503

@turbolent
Copy link
Member

We might want to bring back such integration tests by reviving the Source Compatibility Suite

@SupunS SupunS changed the title Re-enabled disabled contract tests Re-enable disabled contract tests Aug 15, 2023
@j1010001 j1010001 mentioned this issue Sep 27, 2024
Closed
@turbolent
Copy link
Member

Let's remove the tests once the Source Compatibility Suite is testing the contracts again, i.e. when #3608 is complete

@SupunS SupunS mentioned this issue Oct 18, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turbolent turbolent

Labels
Technical Debt Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup outdated FT/NFT related contract codes and tests onflow/cadence
2 participants
@turbolent @dsainati1