Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more integration tests for atree inlining #2837

Closed
fxamacker opened this issue Oct 3, 2023 · 1 comment
Closed

Add more integration tests for atree inlining #2837

fxamacker opened this issue Oct 3, 2023 · 1 comment
Assignees
@turbolent
Labels
Feedback Testing

Comments

@fxamacker
Copy link
Member

Issue to be solved

More integration tests for atree inlining can be added to Cadence after onflow/atree#342 and onflow/atree#345 are merged.

Updates onflow/atree#346

Suggested Solution

Add more integration tests for atree inlining.

For example, inserting a child into a parent, mutating it, removing the child from that parent, mutating it, and then inserting the child into another container, and mutating it.
@fxamacker fxamacker mentioned this issue Oct 3, 2023
Merged
8 tasks
@j1010001
Copy link
Member

what we have now is sufficient after we have smoke tests running successfully.

@fxamacker fxamacker mentioned this issue Nov 2, 2023
Closed
@fxamacker fxamacker mentioned this issue Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turbolent turbolent

Labels
Feedback Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turbolent @j1010001 @fxamacker