Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use actions/setup-go@v2 to speed up CI by ~10 secs and specify Go 1.15.x #970

Closed
fxamacker opened this issue Jun 3, 2021 · 0 comments · Fixed by #971
Closed

Use actions/setup-go@v2 to speed up CI by ~10 secs and specify Go 1.15.x #970

fxamacker opened this issue Jun 3, 2021 · 0 comments · Fixed by #971
Assignees
@fxamacker
Labels
Feature Feedback

Comments

@fxamacker
Copy link
Member

Issue To Be Solved

  • actions/setup-go@v1 has a performance bug which can cost an extra ~10 secs to install Go.
  • ci.yml specifies go-version: "1.15.10" so a newer version of 1.15.x won't be used when available.

See actions/setup-go#39

Suggest A Solution

actions/setup-go@v2 fixes the performance bug and supports ".x" in the version string.

With v2, specifying "1.15.x" will install the latest 1.15 available.

Modify ci.yml to:

  • Use actions/setup-go@v2.
  • Specify go-version: '1.15.x'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxamacker fxamacker

Labels
Feature Feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use actions/setup-go@v2 to speed up CI by ~10 secs and specify Go 1.15.x onflow/cadence
2 participants
@turbolent @fxamacker