Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] View Account link fails for EVM addresses #105

Closed
sisyphusSmiling opened this issue Sep 19, 2024 · 0 comments · Fixed by #110
Closed

[BUG] View Account link fails for EVM addresses #105

sisyphusSmiling opened this issue Sep 19, 2024 · 0 comments · Fixed by #110
Assignees
Labels
bug Something isn't working

Comments

@sisyphusSmiling
Copy link
Contributor

Problem

When funding an EVM address, the link to view the account is invalid. This is likely because the link is generated by appending to a prefix of https://testnet.flowdiver.io/account/, but flowdiver doesn't support viewing EVM addresses at these URLs.

Steps to Reproduce

  1. Fund an EVM address
  2. After success, click on the resulting "View Account" link
  3. The link will lead to an invalid page

Acceptance Criteria

The faucet should differentiate between EVM & Flow account addresses and prepend the appropriate URL prefix. For EVM, that's currently https://evm-testnet.flowscan.io/address/

@sisyphusSmiling sisyphusSmiling added the bug Something isn't working label Sep 19, 2024
@sisyphusSmiling sisyphusSmiling moved this to 🆕 New in 🌊 Flow 4D Sep 19, 2024
@gregsantos gregsantos moved this from 🆕 New to 🔖 Ready for Pickup in 🌊 Flow 4D Sep 26, 2024
@nialexsan nialexsan moved this from 🔖 Ready for Pickup to 🏗 In Progress in 🌊 Flow 4D Dec 17, 2024
@nialexsan nialexsan moved this from 🏗 In Progress to 👀 In Review in 🌊 Flow 4D Dec 17, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in 🌊 Flow 4D Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants