Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account storage inspection #151

Closed
sideninja opened this issue May 20, 2022 · 5 comments · Fixed by #156
Closed

Account storage inspection #151

sideninja opened this issue May 20, 2022 · 5 comments · Fixed by #156
Assignees
Labels
Feature A new user feature or a new package API Feedback

Comments

@sideninja
Copy link
Contributor

Add storage inspection capability to the emulator and expose an API to interact with this feature. This would benefit multiple use cases:

  • Integrating this feature into the CLI would allow other developers to inspect what is stored in the account storage
  • Testing framework can use the storage inspection to assert the correctness of actions
  • The Flowser tool requires storage inspection
  • The playground backend could use this functionality instead of custom implementation

DoD:

  • Implement the feature
  • Release a new version
  • Update the version in the CLI
@sideninja sideninja added Feature A new user feature or a new package API Feedback labels May 20, 2022
@sideninja sideninja self-assigned this May 20, 2022
@bluesign
Copy link
Collaborator

bluesign commented May 20, 2022

This is really great idea, though I am in favor on solving on cadence side ( due to internal changes on storage happening all the time )

I think we have all the parts we need ( though they may be not made it to secure cadence due to non-technical reasons :tinfoilhat: )

when we have this both, we will have this functionality with plus nothing to maintain when something internal changes.

@sideninja
Copy link
Contributor Author

I agree 💯 that this will and should be solved by Cadence but it may take some time to get there, so an abstraction of this functionality in the emulator won't hurt, after Cadence adds this we will just make sure to deprecate the API. This is needed by above-mentioned tools in the short term.

@bluesign
Copy link
Collaborator

Ah then I agree totally with this time frame. Also integration with FlowKit would be super nice.

I am dreaming a bit but also playground backend using FlowKit would be also be a killer feature.

@sideninja
Copy link
Contributor Author

I am dreaming a bit but also playground backend using FlowKit would be also be a killer feature.

Oh, believe we are both dreaming about this ;) actually, I'm already doing some planning on how we could refactor the playground and use flowkit instead, actually not just playground but also vscode extension and just offer that functionality as part of the LS for all the IDEs to use. Super early phase tho, so more planning will be needed but in my mind these are first steps we need to take to get there one day.

@sideninja sideninja mentioned this issue Jun 2, 2022
6 tasks
@sideninja
Copy link
Contributor Author

The PR is almost ready, the implementation works, I need to think about FVM values now and further test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new user feature or a new package API Feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants