Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionResult type differs from protobuf schema #769

Closed
illia-malachyn opened this issue Sep 24, 2024 · 1 comment · Fixed by #774
Closed

TransactionResult type differs from protobuf schema #769

illia-malachyn opened this issue Sep 24, 2024 · 1 comment · Fixed by #774

Comments

@illia-malachyn
Copy link
Contributor

illia-malachyn commented Sep 24, 2024

This is part of #736

TransactionResult type on the SDK side
https://github.com/onflow/flow-go-sdk/blob/master/transaction.go#L620

TransactionResultResponse message in the Protobuf schema
https://github.com/onflow/flow/blob/master/protobuf/flow/access/access.proto#L416

computation_usage field is missing

@peterargue
Copy link
Contributor

https://github.com/onflow/flow/blob/4998e288f99e963c2e6aa2474bf93c93e228a21b/protobuf/flow/access/access.proto#L416-L427

vs

flow-go-sdk/transaction.go

Lines 620 to 628 in 2689460

type TransactionResult struct {
Status TransactionStatus
Error error
Events []Event
BlockID Identifier
BlockHeight uint64
TransactionID Identifier
CollectionID Identifier
}

The main difference is the SDK is missing these fields: metadata, computation_usage.

Let's go ahead and add them.

status_code can be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants