Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Execution state] Compact Batch Proofs #1749

Closed
Tracked by #1744
ramtinms opened this issue Dec 9, 2021 · 2 comments
Closed
Tracked by #1744

[Execution state] Compact Batch Proofs #1749

ramtinms opened this issue Dec 9, 2021 · 2 comments
Labels
Stale Label used when marking an issue stale.

Comments

@ramtinms
Copy link
Contributor

ramtinms commented Dec 9, 2021

Currently, a ledger batch proof is a slice of inclusion proofs, this can be optimized by storing values of the common branches only once. especially for larger batch proofs, the very first few levels of the trie would be the same, another improvement might be that if both children of the same hight is included, both hash values should be computable so we could skip including hash values for those levels.

@Ullaakut
Copy link

We talked about this last time, IIRC, but I can't recall the details you gave about it.

If I understand correctly, the proofs are essentially the list of hashes that go from the root to the paths that we want to prove exists, and so the optimization there is that if in a batch, multiple paths share common parts, we could just include those proofs once, right?

As for the second proposal, I am not sure I understand what you mean by:

If both children of the same height are included, both hash values should be computable so we could skip including hash values for those levels.

Could you please expand on it or explain it in a different way? 🙏

Thanks :)

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Oct 14, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Label used when marking an issue stale.
Projects
None yet
Development

No branches or pull requests

2 participants