Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Execution state] Update mtrie with minor fixes and improvments #1802

Closed
fxamacker opened this issue Jan 4, 2022 · 0 comments · Fixed by #1801
Closed

[Execution state] Update mtrie with minor fixes and improvments #1802

fxamacker opened this issue Jan 4, 2022 · 0 comments · Fixed by #1801
Assignees
@fxamacker
Labels
Improvement

Comments

@fxamacker
Copy link
Member

fxamacker commented Jan 4, 2022 •
edited
Loading

Problem Definition

Several minor issues discovered while reading mtrie code.

  • utils.ReadShortData() shouldn't return "rest" with extra data
  • buffer size is incorrect in flattener.EncodeStorableTrie(), which can cause extra memory alloc
  • unnecessary error conversion code in Ledger.Set()
  • some comments don't match code
  • some tests can be improved

Updates epic #1744

Proposed Solution

See PR opened to resolve this issue.

Definition of Done

PR reviewed and merged with each item resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxamacker fxamacker

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update mtrie with some minor fixes and small improvements onflow/flow-go
1 participant
@fxamacker