Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Execution state] Preallocate slices in mtrie when feasible #1820

Closed
fxamacker opened this issue Jan 10, 2022 · 0 comments · Fixed by #1838
Closed

[Execution state] Preallocate slices in mtrie when feasible #1820

fxamacker opened this issue Jan 10, 2022 · 0 comments · Fixed by #1838
Assignees
@fxamacker
Labels
Execution Cadence Execution Team Performance

Comments

@fxamacker
Copy link
Member

fxamacker commented Jan 10, 2022 •
edited
Loading

Problem Definition

Some slices are not preallocated, causing more frequent memory allocs than necessary.

Updates epic #1744

Proposed Solution

Preallocate slices when feasible.

This optimization is low-risk and should be done before larger optimizations planned in other issues.
@fxamacker fxamacker self-assigned this Jan 10, 2022
@fxamacker fxamacker mentioned this issue Jan 14, 2022
Merged
@fxamacker fxamacker added the Execution Cadence Execution Team label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxamacker fxamacker

Labels
Execution Cadence Execution Team Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preallocate slices in mtrie onflow/flow-go
1 participant
@fxamacker