Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Execution State] Reduce encoded payload value length from 8 bytes to 4 bytes in checkpoint file #2070

Closed
fxamacker opened this issue Feb 25, 2022 · 1 comment
Assignees
Labels
Execution Cadence Execution Team Performance

Comments

@fxamacker
Copy link
Member

fxamacker commented Feb 25, 2022

Problem

Currently, the entire payload length is encoded to 4 bytes while the payload value length is encoded to 8 bytes. So reducing to 4 bytes makes sense.

This encoding is used in checkpoint, TrieUpdate (WAL), and TrieProof. Since this affects code outside checkpoint, it was moved from PR #1944 to this separate issue.

Thanks @ramtinms and @tarakby for confirming we should reduce this length.

Updates epic #1744

The Proposed Solution

Use 4 bytes to encode payload value length instead of 8 bytes.

Caveats

Estimate is 3 (limited scope) or 7 (larger scope) depending on the approach taken to resolve this.

@fxamacker fxamacker self-assigned this Feb 25, 2022
@fxamacker fxamacker changed the title Reduce encoded payload value length from 8 bytes to 4 bytes in checkpoint file [Execution State] Reduce encoded payload value length from 8 bytes to 4 bytes in checkpoint file Feb 28, 2022
@fxamacker
Copy link
Member Author

This was closed by PR #2165 on March 17, 2022.

@fxamacker fxamacker added the Execution Cadence Execution Team label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution Cadence Execution Team Performance
Projects
None yet
Development

No branches or pull requests

1 participant