Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Execution State] LedgerMetrics.LatestTrieRegCountDiff() and LatestTrieMaxDepthDiff() can be called with overflowed value #2092

Closed
fxamacker opened this issue Mar 1, 2022 · 0 comments · Fixed by #2096
Closed

[Execution State] LedgerMetrics.LatestTrieRegCountDiff() and LatestTrieMaxDepthDiff() can be called with overflowed value #2092

fxamacker opened this issue Mar 1, 2022 · 0 comments · Fixed by #2096
Assignees
@fxamacker
Labels
Bug Something isn't working Execution Cadence Execution Team

Comments

@fxamacker
Copy link
Member

fxamacker commented Mar 1, 2022 •
edited
Loading

🐞 Bug Report

LedgerMetrics.LatestTrieRegCountDiff(number uint64) and LatestTrieMaxDepthDiff(number uint64) are called with an expression that subtracts one uint64 from another uint64.

Subtracting one uint64 from another uint64 overflows when the subtracted value is larger.

What is the severity of this bug?

TBD

Additional context

This bug was found during PR resolving issues #1747 and #1748.
@fxamacker fxamacker added the Bug Something isn't working label Mar 1, 2022
@fxamacker fxamacker self-assigned this Mar 1, 2022
@fxamacker fxamacker mentioned this issue Mar 2, 2022
Merged
@fxamacker fxamacker changed the title [Execution State] LedgerMetrics.LatestTrieRegCountDiff(number uint64) can be called with overflowed value [Execution State] LedgerMetrics.LatestTrieRegCountDiff() and LatestTrieMaxDepthDiff() can be called with overflowed value Mar 2, 2022
@fxamacker fxamacker added the Execution Cadence Execution Team label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxamacker fxamacker

Labels
Bug Something isn't working Execution Cadence Execution Team
Projects
None yet
Milestone
No milestone
1 participant
@fxamacker