Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account contract_names duplicates #3825

Closed
janezpodhostnik opened this issue Jan 17, 2023 · 1 comment
Closed

Fix account contract_names duplicates #3825

janezpodhostnik opened this issue Jan 17, 2023 · 1 comment
Assignees
Labels
Execution Cadence Execution Team Stale Label used when marking an issue stale.

Comments

@janezpodhostnik
Copy link
Contributor

Problem Definition

Data inconsistency in some "contracts" registers.

This was reported in cadence onflow/cadence#2252

Some Accounts have duplicated contract names in the contract_names register. This should not be the case.

A scan of the network showed that there are only 2 accounts on mainnet and only a few on testnet that have this problem.

mainnet:

address=f233dcee88fe0abe contract_names=["FungibleToken","FungibleToken","FungibleTokenMetadataViews","FungibleTokenSwitchboard"]
 address=1d7e57aa55817448 contract_names=["MetadataViews","NonFungibleToken","NonFungibleToken"]

Everything points to this being introduced with the initial migration to multiple contracts per account, or by a very old bug.

Proposed Solution

Create a storage migration to fix accounts with this inconsistency.

Definition of Done

For all accounts the contract_names register should not contain duplicates.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution Cadence Execution Team Stale Label used when marking an issue stale.
Projects
None yet
Development

No branches or pull requests

1 participant