Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version, checksum, and partial state indicator to intermediate migration payload file #5437

Closed
fxamacker opened this issue Feb 22, 2024 · 0 comments · Fixed by #5438
Closed
Assignees
Labels
Execution Cadence Execution Team Improvement

Comments

@fxamacker
Copy link
Member

fxamacker commented Feb 22, 2024

We recently added feature for state extraction to produce a payload file (intermediate file during migration) along with a flag to specify desired addresses (accounts) of payloads to include.

This payload file is intended primarily to speedup development, testing, and debugging of migrations.

However, it is possible partial state may also be used accidentally for real migrations.

For these reasons, adds more metadata to the payload file:

  • file format version
  • partial state vs full state indicator (e.g. whether it includes payloads for all accounts or some)
  • checksum

Also, to prevent accidental use of partial state, add a flag to state extraction tool that must be specified by user in order to use payload file not marked as containing full state (i.e. when file doesn't have payloads for all accounts).

Thanks @zhangchiqing for suggestion to add checksum to this payload file, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution Cadence Execution Team Improvement
Projects
None yet
1 participant