Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer dereference in SendAndSubscribeTransactionStatuses() func #6604

Closed
illia-malachyn opened this issue Oct 29, 2024 · 2 comments · Fixed by onflow/flow-go-sdk#798
Closed

Fix nil pointer dereference in SendAndSubscribeTransactionStatuses() func #6604

illia-malachyn opened this issue Oct 29, 2024 · 2 comments · Fixed by onflow/flow-go-sdk#798
Assignees
@Guitarheroua
Labels
S-Access

Comments

@illia-malachyn
Copy link
Contributor

illia-malachyn commented Oct 29, 2024 •
edited
Loading

When you run the flow-go-sdk example for SendAndSubscribeTransactionStatuses, a nil pointer dereference crash occurs during runtime.

Steps to reproduce:

  • open flow-go-sdk/examples folder
  • run the emulator via flow-c1 emulator start -v
  • run the example via make send-and-subscribe-transaction-statuses in a separate terminal

You should see an error in the emulator with nil pointer dereference error.

I assume the error is caused by flow-go implementation rather than flow-go-sdk wrapper one. I'd also suggest refactoring the implementation of this method as it was extended by quite a complex logic and became hard to reason about
@illia-malachyn
Copy link
Contributor Author

cc @peterargue @AndriiDiachuk @Guitarheroua

@illia-malachyn
Copy link
Contributor Author

flow-go-sdk examples are to be merged onflow/flow-go-sdk#794

@illia-malachyn illia-malachyn changed the title Fix nil pointer dereference SendAndSubscribeTransactionStatuses Fix nil pointer dereference in SendAndSubscribeTransactionStatuses() func Oct 29, 2024
@Guitarheroua Guitarheroua self-assigned this Oct 29, 2024
@Guitarheroua Guitarheroua mentioned this issue Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guitarheroua Guitarheroua

Labels
S-Access
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Access] Fix SendAndSubscribeTransactionStatuses and example The-K-R-O-K/flow-go-sdk
2 participants
@Guitarheroua @illia-malachyn