Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EFM] Remove backward-compatibility for flow.DKGIndexMap #6794

Open
2 tasks
Tracked by #6772
durkmurder opened this issue Dec 10, 2024 · 0 comments
Open
2 tasks
Tracked by #6772

[EFM] Remove backward-compatibility for flow.DKGIndexMap #6794

durkmurder opened this issue Dec 10, 2024 · 0 comments
Assignees
Labels
Preserve Stale Bot repellent Protocol Team: Issues assigned to the Protocol Pillar. S-BFT

Comments

@durkmurder
Copy link
Member

durkmurder commented Dec 10, 2024

Context

During Mainnet26, we plan to deploy a change to the EpochCommit data structure, implemented in EFM workstream. In #6785 we introduce a way to handle new changes in a backward-compatible manner:

  • The field is nil-able, and instances where the value is nil are interpreted as the old data model
  • Business logic operating on the data structure have 2 codepaths: one for the old data model (nil field), one for the new data model (non-nil field).

Backward-compatibility is necessary to support a downtime-free upgrade, however we do not want to maintain this extra logic longer than necessary. This issue is to remove extra logic needed for backward-compatibility.

Definition of Done

  • Follow TODO(EFM, #6794) to find all places were logic was modified to support backward-compatibility and remove/update them.
  • Require EpochCommit.DKGIndexMap != nil
@durkmurder durkmurder self-assigned this Dec 10, 2024
@durkmurder durkmurder added Protocol Team: Issues assigned to the Protocol Pillar. Preserve Stale Bot repellent S-BFT labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preserve Stale Bot repellent Protocol Team: Issues assigned to the Protocol Pillar. S-BFT
Projects
None yet
Development

No branches or pull requests

1 participant