Removes unused first height field from LN builder #6828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field reads the first height of an epoch, which may be unavailable if the node is using Dynamic Bootstrap.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6828 +/- ##
==========================================
+ Coverage 41.15% 41.19% +0.03%
==========================================
Files 2065 2109 +44
Lines 182499 185660 +3161
==========================================
+ Hits 75116 76475 +1359
- Misses 101077 102777 +1700
- Partials 6306 6408 +102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
approved these changes
Dec 19, 2024
AlexHentschel
approved these changes
Dec 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jordanschalm
requested review from
durkmurder,
zhangchiqing,
Kay-Zee,
janezpodhostnik and
tarakby
as code owners
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field reads the first height of an epoch, which may be unavailable if the node is using Dynamic Bootstrap.