Contracts under dependencies fields cannot be properly loaded when config them in deployment fields.

[btspoony]

Instructions

If the contract only exists in the dependencies field and not in the contracts field of flow.json, when it is configured in the deployment field, the vscode plugin will report an error and language server will be broken.

Problem

The language server will be broken with a error thrown.

Steps to Reproduce

Acceptance Criteria

contracts in the dependencies field can be add to deployment field and no error occurs.

Context

VSCode plugin: v2.2.1
flow-cli: v1.13.2

[btspoony]

There is another issue, if dependencies are not configured in the contracts field.
An importing error will be reported.

After adding all dependencies to the contracts field, then it works.

[jribbink]

@btspoony

Is this still an issue in the latest version of the Flow CLI (I can't reproduce it on v1.18.0)? We had an issue where the Cadence Language server was using an outdated version of flowkit (which meant in turn that dependency manager didn't work in the LS).

But I believe this issue should be fixed now.

[btspoony]

Yeah, it is fixed now.
I removed all duplicated contracts in contracts fields. and it works.

[btspoony]

fixed after https://github.com/onflow/flow-cli/releases/tag/v1.18.0

[jribbink]

Amazing, glad to hear