Check passing initialized modules #105
kulbachcedric
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Summary
This issue proposes changes to enhance flexibility in handling PyTorch modules by allowing initialized modules to be passed to the base classes. This could help streamline workflows where pre-initialized or pre-trained models are frequently used.
Current Implementation
The current Regressor and similar classes require a module type (Type[torch.nn.Module]) to instantiate a model internally. This design works well for simple use cases but restricts flexibility when users need to use pre-initialized modules.
Discussion Points
Impact on Existing Workflows:
Will allowing initialized modules complicate initialization for existing users?
Documentation Updates:
How should we structure documentation to highlight this change?
However, with this change we would diverge from skorch.
Best
Cedric
Beta Was this translation helpful? Give feedback.
All reactions