-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Prevent deleting core elements #851
Comments
@Kitenite |
@iNerdStack , I think it's more so that users don't know what they should not be deleting. Perhaps we can prevent deletion if the element's parent is NOT another jsx element? |
Oh, thats clearer now. yes that should work |
@Kitenite this was merged in yea? can we close this out? |
Describe the bug
There's been instances of people playing around and deleting core elements like body tags or core div tag. Then surprise pikachu face when the whole page stops working.
This is a failure of communication on our part. We should add guard rails for core elements. Some cases may be:
See this great work on preventing deleting array elements by @iNerdStack for inspiration #786
The text was updated successfully, but these errors were encountered: