Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf version conflict between tf2onnx and tensorflow #2243

Closed
marqueurs404 opened this issue Sep 20, 2023 · 2 comments
Closed

Protobuf version conflict between tf2onnx and tensorflow #2243

marqueurs404 opened this issue Sep 20, 2023 · 2 comments
Labels
question An issue, pull request, or discussion needs more information

Comments

@marqueurs404
Copy link

Ask a Question

Question

The release logs of version 1.15 of tf2onnx mentioned supporting TensorFlow 2.12/2.13. However, when I tried to pip install tf2onnx 1.15 and tensorflow 2.12 or 2.13, there is clearly a version conflict preventing the pip install.

Further information

image

@marqueurs404 marqueurs404 added the question An issue, pull request, or discussion needs more information label Sep 20, 2023
@marqueurs404
Copy link
Author

Closing as the conflict was happening with another related library not, not tf2onnx

@Zahlii
Copy link

Zahlii commented Oct 25, 2023

I would like to re-open this issue, while the comment above is true (in the sense that you can manage to resolve tensorflow and tf2onnx in a clean virtualenv), it will lead to protobuf ~=3.20 to be installed.

This was only changed from tf2onnx 1.15 onwards (see #2171)

If I want to install this together with some GRPC dependencies, this will resolve to the following setup - note that this is using the most recent protobuf version, but "downgrade" tf2onnx. Will this lead to issues with tf2onnx 1.14? What was the original reason on why to include the protobuf pin?

    #7 2.483 protobuf==4.24.4
    #7 2.483 ├── grpcio-reflection==1.59.0 [requires: protobuf>=4.21.6]
    #7 2.483 ├── grpcio-tools==1.59.0 [requires: protobuf>=4.21.6,<5.0dev]
    #7 2.483 ├── onnx==1.14.1 [requires: protobuf>=3.20.2]
    #7 2.483 │   └── tf2onnx==1.14.0 [requires: onnx>=1.4.1]
    #7 2.483 ├── onnxruntime==1.16.1 [requires: protobuf]
    #7 2.483 ├── tensorboard==2.12.3 [requires: protobuf>=3.19.6]
    #7 2.483 │   └── tensorflow==2.12.1 [requires: tensorboard>=2.12,<2.13]
    #7 2.483 └── tensorflow==2.12.1 [requires: protobuf>=3.20.3, <5.0.0dev,!=4.21.5,!=4.21.4,!=4.21.3,!=4.21.2,!=4.21.1,!=4.21.0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question An issue, pull request, or discussion needs more information
Projects
None yet
Development

No branches or pull requests

2 participants