Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify naming for builds and evaluations #26

Closed
jeremyfowers opened this issue Dec 1, 2023 · 0 comments · Fixed by #65
Closed

Clarify naming for builds and evaluations #26

jeremyfowers opened this issue Dec 1, 2023 · 0 comments · Fixed by #65
Assignees
Labels
breaking API breaking change that should get extra testing in canary cleanup Cleaning up old/unused code and tech debt p1 Medium priority
Milestone

Comments

@jeremyfowers
Copy link
Collaborator

jeremyfowers commented Dec 1, 2023

Problem statement

the API is named "add_build_stat()" - that should be renamed to something more general

I was thinking of evaluation as a superset of build+benchmark

Proposal

  • in the stats.yaml: builds -> evaluations
  • add_build_stat() -> save_model_evaluation_stat()
  • stat_id -> evaluation_id
  • save_stat() -> save_model_stat()

cc @danielholanda

@jeremyfowers jeremyfowers added cleanup Cleaning up old/unused code and tech debt p1 Medium priority labels Dec 1, 2023
@jeremyfowers jeremyfowers added this to the Version 1.0 milestone Dec 2, 2023
@jeremyfowers jeremyfowers added the breaking API breaking change that should get extra testing in canary label Dec 4, 2023
@jeremyfowers jeremyfowers changed the title Clarify naming for evaluation stats Clarify naming for builds and evaluations Dec 4, 2023
@jeremyfowers jeremyfowers self-assigned this Dec 4, 2023
@jeremyfowers jeremyfowers reopened this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking API breaking change that should get extra testing in canary cleanup Cleaning up old/unused code and tech debt p1 Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant