Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the set_success stage #36

Closed
jeremyfowers opened this issue Dec 1, 2023 · 0 comments · Fixed by #65
Closed

Remove the set_success stage #36

jeremyfowers opened this issue Dec 1, 2023 · 0 comments · Fixed by #65
Assignees
@jeremyfowers
Labels
breaking API breaking change that should get extra testing in canary cleanup Cleaning up old/unused code and tech debt p1 Medium priority ui/ux Improve the user experience
Milestone
Version 1.0

Comments

@jeremyfowers
Copy link
Collaborator

The set_success stage is a technical debt that provides a surface area for bugs and confusing reporting. We should probably remove it (or at least rename it).

cc @danielholanda
@jeremyfowers jeremyfowers added cleanup Cleaning up old/unused code and tech debt ui/ux Improve the user experience p0 Top priority p1 Medium priority and removed p0 Top priority labels Dec 1, 2023
@jeremyfowers jeremyfowers added this to the Version 1.0 milestone Dec 2, 2023
@jeremyfowers jeremyfowers added the breaking API breaking change that should get extra testing in canary label Dec 4, 2023
@jeremyfowers jeremyfowers self-assigned this Dec 4, 2023
This was referenced Dec 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremyfowers jeremyfowers

Labels
breaking API breaking change that should get extra testing in canary cleanup Cleaning up old/unused code and tech debt p1 Medium priority ui/ux Improve the user experience
Projects
None yet
Milestone
Version 1.0
Development

Successfully merging a pull request may close this issue.

36-remove-the-set_success-stage onnx/turnkeyml
Release v1.0.0 onnx/turnkeyml
1 participant
@jeremyfowers