re-enable valgrind on OSX

[onqtam]

before the 1.0.0 release I disabled the use of valgrind even for 64 bit builds because 2/3 of all OSX builds failed after I added better examples testing more of the features of the framework (mainly what happens when an assert/test case throws unexpectedly) - this is the commit that disables the use of valgrind.

I'm 100% sure the problem isn't in doctest - so I'm hoping for some workaround (or a suppression file for valgrind might be the correct solution)

here is the travis build that failed... Check out the specific builds that failed and search for "error"

[dascandy]

That looks like Valgrind is finding only the memory that it itself allocated as a leak. Bug in valgrind?

[onqtam]

All builds have used valgrind version 3.11.0 - and by looking at the logs to check out what homebrew gets exactly:

failed builds use:

• valgrind-3.11.0.el_capitan.bottle.tar.gz
• valgrind-3.11.0.mavericks.bottle.tar.gz

passing builds use:

• valgrind-3.11.0.mavericks.bottle.tar.gz
• valgrind-3.11.0.yosemite.bottle.tar.gz

and the mavericks build of valgrind is present in both passing and failing builds.

My suspicion is that there is a bug in the standard library from the compiler itself - and not in valgrind.

Anyway I don't have a mac and someone else has to investigate/suppress this.

[onqtam]

Since quite a bit of time valgrind tests under OSX are also disabled for 32 bit builds... But I don't consider this as an important issue.

[cdeln]

Also valgrind is not supported on ARM/macOS , so any apple computer sold since 2020...

How does sanitizers compete with valgrind? My feeling is that they tend to catch the same stuff these days, I rarely need to drop into valgrind anymore except when the sanitizer itself has a bug.