-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thread_local is not supported on iOS 9.0 #164
Comments
I'm afraid this one will be a bit harder to fix than #163 ... |
On the top of my head - version 1.2.8 doesn't use anything thread-local and is C++98 - there is also a git tag... for now that is the best I can offer. The interface (API) is the same. I suppose iOS 9 will be out of support soon...? |
Fair enough, I don't really need to build tests on iOS anyway, if I do, I'll go back to 1.2.8. Thanks! |
Although the issue is closed as of right now, I'd like to share how I solved this problem. Right now, I'm building with MinGW clang (on Windows), which has some issues with thread_local. Fortunately, using a custom implementation of thread_local (https://github.com/wang-bin/ThreadLocal) solved the issue, although I had to edit a few lines of code in doctest.h. Maybe in a later release, we could add the custom implementation for platforms not supporting thread_local (such as MinGW clang, vs2013, and some versions of iOS/Android). |
@lasagnaphil I actually made it possible to use the latest doctest version All you have to do is just to define |
Description
thread_local
is not supported on iOS 9.0.Steps to reproduce
Extra information
The text was updated successfully, but these errors were encountered: