You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm back with more warnings from an even more obscure setup.
CMake 3.15 just released with support for using clang/clang++ on Windows instead of clang-cl. Compiling doctest with this results in a few issues:
clang++ on Windows needs to be in C++14 mode to work with MSVC stdlib headers.
We can solve this by setting the doctest_with_main standard to C++14 if this specific setup is used.
Some unused macro warnings:
../doctest/parts/doctest.cpp:3:9: warning: macro is not used [-Wunused-macros]
#define DOCTEST_LIBRARY_IMPLEMENTATION
^
../doctest/parts/doctest.cpp:130:9: warning: macro is not used [-Wunused-macros]
#define VC_EXTRA_LEAN
^
I'm not sure if these are false positives or actually valid.
A non-portable system include warning:
../doctest/parts\doctest.cpp:140:10: error: non-portable path to file '<Windows.h>'; specified path differs in case from file name on disk [-Werror,-Wnonportable-system-include-path]
#include <windows.h>
^~~~~~~~~~~
<Windows.h>
The text was updated successfully, but these errors were encountered:
wow - the unused macro DOCTEST_LIBRARY_IMPLEMENTATION warning is weird - it's a standard include guard technique... maybe the compiler distinguishes between .cpp and .h files and reports it only for defines from a .cpp file......
* Use Windows.h instead of windows.h
Fixes part of #253.
* Remove `VC_EXTRA_LEAN`.
Fixes part of #253. `VC_EXTRA_LEAN` doesn't appear anywhere in Windows.h
(at least on my machine, only `WIN32_LEAN_AND_MEAN` does) so it seems
safe to remove it.
* Ignore Wunused-macros warning for DOCTEST_LIBRARY_IMPLEMENTATION.
Removing the macro lead to compilation errors so its definitely a false
positive.
I'm back with more warnings from an even more obscure setup.
CMake 3.15 just released with support for using clang/clang++ on Windows instead of clang-cl. Compiling doctest with this results in a few issues:
We can solve this by setting the
doctest_with_main
standard to C++14 if this specific setup is used.I'm not sure if these are false positives or actually valid.
The text was updated successfully, but these errors were encountered: