Remove architecture check from CMake package #225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CMake adds an architecture check to each package by default. This causes the package to break if e. g. the package was built on a 32 bit system and used on a 64 bit system, even though this is a header-only library. This can happen if a caching package manager like conan is being used.
In CMake 3.14 this check can be disabled by passing
ARCH_INDEPENDENT
towrite_basic_package_version_file
. In versions prior to thatCMAKE_SIZEOF_VOID_P
needs to be unset for the duration of this function.GitHub Issues
catchorg/Catch2#1368