Fixed missing ostream include for MacOS when defining DOCTEST_CONFIG_… #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to let you know - sorry for the delay, but I'll think about this perhaps in January 2020... Others keep hitting this issue ( #316 ) and I will eventually get to it! |
|
I decided to merge this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…USE_STD_HEADERS
Description
ostream isn't getting included on MacOS 10.13 when building with cmake. Doctest seems to rely on string including ostream when that is not reliable. As including ostream was already included for VS 2019 it makes sense to include it for all platforms that might need it when using the DOCTEST_CONFIG_USE_STD_HEADERS define.
GitHub Issues
This fixes #126