Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to catching unhandled exceptions on Windows Closes #324 #325

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

jkriegshauser
Copy link
Contributor

Description

GitHub Issues

Closes #324

@onqtam
Copy link
Member

onqtam commented Jan 15, 2020

Hi - thanks for this fix! Can you confirm that doctest continues to capture correctly the crash from code such as int* p = 0; *p = 1; if there isn't a __try section in the test case?

I don't think the changes made to .gitignore should be part of this PR (especially adding the *.cmake wildcard) - making an out-of-source build should be preferred.

@jkriegshauser
Copy link
Contributor Author

Yes, in the case you mention, a SIGSEGV continues to be caught and reported by doctest as it was before the fix.

I can revert the changes to .gitignore. For out-of-source builds, what parameters are you running CMake with to build out-of-source. I'd recommend adding a building guide to CONTRIBUTING.md, and include info about how to build, run tests, add tests, etc. :)

@onqtam
Copy link
Member

onqtam commented Jan 15, 2020

About the out-of-source builds - I usually make a build directory within the doctest directory and call cmake from there like this: cmake .. - standard CMake practice - that build directory already has an entry in the .gitignore, but it can be outside of the doctest folder as well - all you need to do is pass the path the root of the doctest repository do CMake. Perhaps I should indeed add some info in CONTRIBUTING.md :)

I'm merging this. Thanks!

@onqtam onqtam merged commit 040fd71 into doctest:dev Jan 15, 2020
onqtam pushed a commit that referenced this pull request Feb 24, 2020
* Switch to catching unhandled exceptions on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants