You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have tests that are emitting Measure is deprecated and will be removed in Ginkgo V2. Please migrate to gomega/gmeasure after upgrading to V2.
However, according to the v2 docs, the functionality was removed and tests aren't even run.
Since v2 was a breaking change from v1, shouldn't Measure() instead just cause failures, similar to how other calls to deprecated functionality do? If not, can the message at least be changed from will be removed in Ginkgo V2 to has been removed as of Ginkgo V2 and these tests are not being run or something similar?
The text was updated successfully, but these errors were encountered:
hey - thanks. it should say has been removed as of Ginkgo V2 and these tests are not being run. I'll fix that.
I'd like to keep the "deprecation" behavior in place however, as opposed to failing the test, as it provides a gentler onramp for folks migrating from V1.
We have tests that are emitting
Measure is deprecated and will be removed in Ginkgo V2. Please migrate to gomega/gmeasure
after upgrading to V2.However, according to the v2 docs, the functionality was removed and tests aren't even run.
Since v2 was a breaking change from v1, shouldn't
Measure()
instead just cause failures, similar to how other calls to deprecated functionality do? If not, can the message at least be changed fromwill be removed in Ginkgo V2
tohas been removed as of Ginkgo V2 and these tests are not being run
or something similar?The text was updated successfully, but these errors were encountered: