Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail using Go 1.18 #531

Closed
BooleanCat opened this issue Mar 21, 2022 · 0 comments · Fixed by #532
Closed

Tests fail using Go 1.18 #531

BooleanCat opened this issue Mar 21, 2022 · 0 comments · Fixed by #532

Comments

@BooleanCat
Copy link
Contributor

To reproduce, simply run ginkgo -r using Go 1.18.

The following specs fail:

Summarizing 3 Failures:
  [FAIL] .CompileTest a remote package [It] compiles the specified test package
  /home/tom/workspace/gomega/gexec/build_test.go:139
  [FAIL] .CompileTestWithEnvironment a remote package [It] compiles the specified test package with the specified env vars
  /home/tom/workspace/gomega/gexec/build_test.go:207
  [FAIL] .CompiledTestIn a remote package [It] compiles the specified test package
  /home/tom/workspace/gomega/gexec/build_test.go:261

In Go 1.18, go get fails when not run in a go module. go install should be used in order to install go binaries on the GOPATH now, however go install will fail when not targeting a main package.
This was referenced Mar 21, 2022
Merged
Merged
@onsi onsi closed this as completed in #532 Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for Go 1.18
1 participant
@BooleanCat