You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Yes, I'm currently upgrading from 0.11 to 0.19 and this is something that we used in that version.
We have proprietary headers that are sent with an INVITE from a legacy client. The client that uses SIP.js needs to answer with matching headers if the headers were part of an incoming INVITE.
Describe the solution you'd like
Add support to supply extra headers when accepting an incoming invite.
Both InvitationProgressOptions and InvitationRejectOptions contain extraHeaders, but not InvitationAcceptOptions.
Is there a reason why the option to add extra headers to the 200 Ok on an incoming invite was removed? I can't find anything in any changelogs (although I can't say I've read every commit message, so I might have missed it).
Describe alternatives you've considered
I posted a question in the Google Group and got an answer with a suggestion, but sadly that workaround won't work since the property that I would need to override (Invitation.autoSendAnInitialProvisionalResponse) is readonly.
I could simply trigger another Invitation.progress() with the extra headers, but that still wouldn't help in my case since the other clients, which I have no control over, only checks the headers on the 200 Ok.
Even if it would work, it seems pretty hacky.
Edit: It's possible to override sendInitialProvisionalResponse on the UserAgent instead, and manually trigger a progress on invitations with the extra headers. But as I mentioned before it still doesn't solve my issue since I need the headers on the 200 Ok instead.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Yes, I'm currently upgrading from 0.11 to 0.19 and this is something that we used in that version.
We have proprietary headers that are sent with an INVITE from a legacy client. The client that uses SIP.js needs to answer with matching headers if the headers were part of an incoming INVITE.
Describe the solution you'd like
Add support to supply extra headers when accepting an incoming invite.
Both
InvitationProgressOptions
andInvitationRejectOptions
contain extraHeaders, but notInvitationAcceptOptions
.Is there a reason why the option to add extra headers to the 200 Ok on an incoming invite was removed? I can't find anything in any changelogs (although I can't say I've read every commit message, so I might have missed it).
Describe alternatives you've considered
I posted a question in the Google Group and got an answer with a suggestion, but sadly that workaround won't work since the property that I would need to override (
Invitation.autoSendAnInitialProvisionalResponse
) is readonly.I could simply trigger another
Invitation.progress()
with the extra headers, but that still wouldn't help in my case since the other clients, which I have no control over, only checks the headers on the 200 Ok.Even if it would work, it seems pretty hacky.
Edit: It's possible to override
sendInitialProvisionalResponse
on theUserAgent
instead, and manually trigger a progress on invitations with the extra headers. But as I mentioned before it still doesn't solve my issue since I need the headers on the 200 Ok instead.The text was updated successfully, but these errors were encountered: