Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See the state of our tests in GOO #9

Closed
Tracked by #237
syphax-bouazzouni opened this issue Mar 2, 2022 · 0 comments
Closed
Tracked by #237

See the state of our tests in GOO #9

syphax-bouazzouni opened this issue Mar 2, 2022 · 0 comments

Comments

@syphax-bouazzouni
Copy link

syphax-bouazzouni commented Mar 2, 2022

State

Use an old version of minitest (maybe update it ?)
Ruby version used: 2.6.9

To reproduce

Build and run the docker-compose produced bu NCBO

docker-compose up -d

Run the tests

bundle exec rake test TESTOPTS="-v"

Results in upstream (NCBO master branch)

test_basic_persistence.rb ✅

Finished tests in 15.320388s, 0.0653 tests/s, 0.3264 assertions/s.
1 tests, 5 assertions, 0 failures, 0 errors, 0 skips

test_cache.rb ⛔️

Finished tests in 11.519089s, 0.0868 tests/s, 0.4341 assertions/s.
1 tests, 5 assertions, 5 failures, 4 errors, 0 skips

  1. Error:
    TestCache#test_cache_models_back_door:
RestClient::NotFound: 404 Not Found

test_chunks_write.rb ⛔️

4, 7,12,15) Failure:
TestChunkWrite::TestChunkWrite#test_reentrant_queries

[/Users/bouazzouni/Work/ontoportal_projects/goo/test/test_chunks_write.rb:115]:
Failed assertion, no message given.

1, 2, 3, 5, 6, 8, 9,10, 11, 13,14,16) Error:

TestChunkWrite::TestChunkWrite#test_put_delete_data:
Errno::EPIPE: Broken pipe

1 tests, 5 assertions, 4 failures, 12 errors, 0 skips

test_collections.rb ✅

Finished tests in 2.409705s, 0.4150 tests/s, 2.0749 assertions/s.
1 tests, 5 assertions, 0 failures, 0 errors, 4 skips

test_dsl_settings.rb ✅ (works after fix)

working if we change RuntimeError to FrozenError

Finished tests in 0.708128s, 1.4122 tests/s, 7.0609 assertions/s.
1 tests, 5 assertions, 0 failures, 0 errors, 0 skips

test_enum.rb ✅

Finished tests in 0.434906s, 2.2993 tests/s, 11.4967 assertions/s.
1 tests, 5 assertions, 0 failures, 0 errors, 0 skips

test_index.rb ⛔️

Can't run, having this output

running test with slice_loading_size=1
/Users/bouazzouni/.rbenv/versions/2.6.9/lib/ruby/2.6.0/net/http/generic_request.rb:207:in `write': Broken pipe (Errno::EPIPE)

test_inmutable.rb ✅

Finished tests in 3.938002s, 0.2539 tests/s, 1.2697 assertions/s.
1 tests, 5 assertions, 0 failures, 0 errors, 0 skips

test_inverse.rb ✅

Finished tests in 3.785190s, 0.2642 tests/s, 1.3209 assertions/s.
1 tests, 5 assertions, 0 failures, 0 errors, 0 skips

test_model_complex.rb ⛔️

Finished tests in 26.811531s, 0.0373 tests/s, 0.1865 assertions/s.

1 to 4 ) Failure:
TestComplex::TestModelComplex#test_aggregate [/Users/bouazzouni/Work/ontoportal_projects/goo/test/test_model_complex.rb:569]:
Failed assertion, no message given.
The cause is the ancestors and descendants that are not transitive even the option set to true
image

See below the graph used to test the ancestors and descendants
image

1 tests, 5 assertions, 4 failures, 0 errors, 0 skips

test_name_with.rb ✅

Finished tests in 1.278154s, 0.7824 tests/s, 3.9119 assertions/s.
1 tests, 5 assertions, 0 failures, 0 errors, 0 skips

test_namespaces.rb ✅ (works after fixes)

First nothing happened the test was not a MiniTest::Unit::TestCase, so i changed from extending GooTest to MiniTest::Unit::TestCase.
After it showed some errors, fixed with some fixes
To finally have all the assertions success
Finished tests in 0.619597s, 1.6140 tests/s, 8.0698 assertions/s.

1 tests, 5 assertions, 0 failures, 0 errors, 0 skips

test_read_only.rb ✅ (but there are 4 tests skipped)

Finished tests in 35.614076s, 0.0562 tests/s, 0.2808 assertions/s.

2 tests, 10 assertions, 0 failures, 0 errors, 4 skips

  1. Skipped:
    TestReadOnly::TestReadOnlyWithStruct#test_embed_struct [/Users/bouazzouni/Work/ontoportal_projects/goo/test/test_read_only.rb:42]:
    not yet

  2. Skipped:
    TestReadOnly::TestReadOnlyWithStruct#test_embed_struct [/Users/bouazzouni/Work/ontoportal_projects/goo/test/test_read_only.rb:42]:
    not yet

  3. Skipped:
    TestReadOnly::TestReadOnlyWithStruct#test_embed_struct [/Users/bouazzouni/Work/ontoportal_projects/goo/test/test_read_only.rb:42]:
    not yet

  4. Skipped:
    TestReadOnly::TestReadOnlyWithStruct#test_embed_struct [/Users/bouazzouni/Work/ontoportal_projects/goo/test/test_read_only.rb:42]:
    not yet

test_schemaless.rb ⛔️

Can't run
running test with slice_loading_size=1
/Users/bouazzouni/.rbenv/versions/2.6.9/lib/ruby/2.6.0/net/http/generic_request.rb:207:in write': Broken pipe (Errno::EPIPE) from /Users/bouazzouni/.rbenv/versions/2.6.9/lib/ruby/2.6.0/net/http/generic_request.rb:207:in copy_stream'

test_search.rb ✅ (works after fix)

Finished tests in 0.688619s, 1.4522 tests/s, 7.2609 assertions/s.
1 tests, 5 assertions, 0 failures, 24 errors, 0 skips

1 to 24) Error:
TestSearch::TestModelSearch#test_search:

ArgumentError: wrong number of arguments (given 1, expected 0)
    /Users/bouazzouni/Work/ontoportal_projects/goo/test/test_search.rb:24:in `index_doc'
    /Users/bouazzouni/Work/ontoportal_projects/goo/lib/goo/search/search.rb:50:in `indexable_object'
    /Users/bouazzouni/Work/ontoportal_projects/goo/lib/goo/search/search.rb:13:in `index'
    /Users/bouazzouni/Work/ontoportal_projects/goo/test/test_search.rb:65:in `test_search'

After changing the function in the test from def index_doc() to def index_doc(to_set=nil) it works.

Finished tests in 2.305359s, 0.4338 tests/s, 2.1689 assertions/s.
1 tests, 5 assertions, 0 failures, 0 errors, 0 skips

test_where.rb ✅

Finished tests in 17.413890s, 0.0574 tests/s, 0.2871 assertions/s.

1 tests, 5 assertions, 0 failures, 0 errors, 0 skips

We have a warning TestWhere#test_where_simple = /Users/bouazzouni/Work/ontoportal_projects/goo/test/test_where.rb:36: warning: constant ::Fixnum is deprecated => to fix change Fixnum to Integer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant